Open naazy opened 6 years ago
@naazy, hoorah! π It's review time! π
I couldn't help but notice that there isn't an in-progress
label on this pull request and a Reviewer
has been added...makes me think that this pull request is ready for review π€
To save you time β³ I've added the Reviewer as an Assignee and I've added the awaiting-review
label - automatically - just like magic! π© π° β¨. Please correct me if I'm wrong, but if I got it right
this time I hope it helps you! π
Any questions, complaints, feedback, contributions? If you prefer, you can also send us anonymous feedback: https://dwyl-feedback.herokuapp.com/feedback/new
@naazy, hoorah! π It's review time! π
I couldn't help but notice that there isn't an in-progress
label on this pull request and a Reviewer
has been added...makes me think that this pull request is ready for review π€
To save you time β³ I've added the Reviewer as an Assignee and I've added the awaiting-review
label - automatically - just like magic! π© π° β¨. Please correct me if I'm wrong, but if I got it right
this time I hope it helps you! π
Any questions, complaints, feedback, contributions? If you prefer, you can also send us anonymous feedback: https://dwyl-feedback.herokuapp.com/feedback/new
@naazy, hoorah! π It's review time! π
I couldn't help but notice that there isn't an in-progress
label on this pull request and a Reviewer
has been added...makes me think that this pull request is ready for review π€
To save you time β³ I've added the Reviewer as an Assignee and I've added the awaiting-review
label - automatically - just like magic! π© π° β¨. Please correct me if I'm wrong, but if I got it right
this time I hope it helps you! π
Any questions, complaints, feedback, contributions? If you prefer, you can also send us anonymous feedback: https://dwyl-feedback.herokuapp.com/feedback/new
Merging #153 into master will decrease coverage by
1.43%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #153 +/- ##
==========================================
- Coverage 98.32% 96.89% -1.44%
==========================================
Files 23 23
Lines 179 193 +14
==========================================
+ Hits 176 187 +11
- Misses 3 6 +3
Impacted Files | Coverage Ξ | |
---|---|---|
web/controllers/github_api/in_memory.ex | 100% <ΓΈ> (ΓΈ) |
:arrow_up: |
web/controllers/rules/pr/awaiting_review.ex | 88.88% <100%> (-11.12%) |
:arrow_down: |
web/models/user.ex | 50% <0%> (-50%) |
:arrow_down: |
web/controllers/rules/issue/time_estimation.ex | 100% <0%> (ΓΈ) |
:arrow_up: |
web/controllers/rules/pr/merge_conflict.ex | 100% <0%> (ΓΈ) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Ξ = absolute <relative> (impact)
,ΓΈ = not affected
,? = missing data
Powered by Codecov. Last update 4d1b10f...0175cfe. Read the comment docs.
:warning: @naazy, the pull request is in "awaiting-review" but some tests are failing. Please fix the tests and reassign when ready :+1: Thanks
Any questions, complaints, feedback, contributions? If you prefer, you can also send us anonymous feedback: https://dwyl-feedback.herokuapp.com/feedback/new
:warning: @naazy, the pull request is in "awaiting-review" but some tests are failing. Please fix the tests and reassign when ready :+1: Thanks
Any questions, complaints, feedback, contributions? If you prefer, you can also send us anonymous feedback: https://dwyl-feedback.herokuapp.com/feedback/new
:warning: @naazy, the pull request is in "awaiting-review" but some tests are failing. Please fix the tests and reassign when ready :+1: Thanks
Any questions, complaints, feedback, contributions? If you prefer, you can also send us anonymous feedback: https://dwyl-feedback.herokuapp.com/feedback/new
:warning: @naazy, the pull request is in "awaiting-review" but some tests are failing. Please fix the tests and reassign when ready :+1: Thanks
Any questions, complaints, feedback, contributions? If you prefer, you can also send us anonymous feedback: https://dwyl-feedback.herokuapp.com/feedback/new
:warning: @naazy, the pull request is in "awaiting-review" but some tests are failing. Please fix the tests and reassign when ready :+1: Thanks
Any questions, complaints, feedback, contributions? If you prefer, you can also send us anonymous feedback: https://dwyl-feedback.herokuapp.com/feedback/new
:warning: @naazy, the pull request is in "awaiting-review" but some tests are failing. Please fix the tests and reassign when ready :+1: Thanks
Any questions, complaints, feedback, contributions? If you prefer, you can also send us anonymous feedback: https://dwyl-feedback.herokuapp.com/feedback/new
:warning: @naazy, the pull request is in "awaiting-review" but some tests are failing. Please fix the tests and reassign when ready :+1: Thanks
Any questions, complaints, feedback, contributions? If you prefer, you can also send us anonymous feedback: https://dwyl-feedback.herokuapp.com/feedback/new
:warning: @naazy, the pull request is in "awaiting-review" but some tests are failing. Please fix the tests and reassign when ready :+1: Thanks
Any questions, complaints, feedback, contributions? If you prefer, you can also send us anonymous feedback: https://dwyl-feedback.herokuapp.com/feedback/new
Not quite sure why coverage has suddenly dropped :cry:
correcting wording on PR message #149