dwyl / dwylbot

:robot: Automating our GitHub Workflow to improve team communication/collaboration and reduce tedious repetition!
28 stars 7 forks source link

Remove oauth #172

Closed SimonLab closed 6 years ago

SimonLab commented 6 years ago

The application contains some endpoints linked to some oauth authentication feature. This authentication was used at the beginning of this project when Github apps wasn't yet implemented. dwylbot doesn't use any authentication so we can remove all this unnecessary code

nelsonic commented 6 years ago

@SimonLab what access can the GitHub application have? e.g:

SimonLab commented 6 years ago

I will check if the "repository administration" permission can allow dwylbot to access this updates

At the moment dwylbot has the following permissions: image

The two only write access are on the issues and pull requests. I'll create an issue to review the permissions list and see if all of them are necessary. We could always update the permissions depending on the new rules implemented.

Otherwise dwylbot is listening to the follwing events, again it's something that we can review and update image

nelsonic commented 6 years ago

thanks @SimonLab 😉