search

dwyl / dwylbot

:robot: Automating our GitHub Workflow to improve team communication/collaboration and reduce tedious repetition!
28 stars 7 forks source link

QA Applying "in-review" label triggers call dwyl/time API to start Timer #20

Closed nelsonic closed 7 years ago

nelsonic commented 7 years ago

As a QA reviewing many Pull Requests per day I would love my act of applying the in-review label to a PR to start my Timer So that it counts how long I've been reviewing the PR and I don't have to manually select the project and click "start".

Ideally the timer should be stopped when the PR is Merged or in-review label removed and assigned back to the person who created the PR.

At present I a manually click "Start Timer" after I have applied the in-review label. If we are going to scale the review of code we need a way of automatically starting Timers. This functionality will also apply to in-progress #7

ghost commented 7 years ago

@nelsonic is this part of the time app or dwylbot?

iteles commented 7 years ago

@markwilliamfirth The trigger mentioned in this issue needs to come from dwylbot.

This cannot be done until there is an API to make a call to so I would suggest adding an external-dependency label to this one and bumping down the priority.

ghost commented 7 years ago

I didn't think we were allowed external-dependency labels in dev repos 😛

ghost commented 7 years ago

@iteles could Time not utilise the same API that dwylbot is utilising in order to know when the "in-review" label is applied?

ghost commented 7 years ago

Closing as duplicate of https://github.com/dwyl/dwylbot/issues/120#issuecomment-310428431