dwyl / dwylbot

:robot: Automating our GitHub Workflow to improve team communication/collaboration and reduce tedious repetition!
28 stars 7 forks source link

Add credo and deploy #34

Closed ghost closed 7 years ago

ghost commented 7 years ago

Add credo and deploy

SimonLab commented 7 years ago

Adding credo will report some errors on the project. I will need some time to go over them so I've added a 2h estimation

SimonLab commented 7 years ago

Just had a look at the documentation of credo: http://credo-ci.org and install the package in mix.exs then running credo mix credo --strict gave me: screenshot from 2017-05-10 13-30-11 screenshot from 2017-05-10 13-30-26

note: Unfortunately there the info notice about my version of Elixir can't be resolve easily on Fedora. The latest package at the moment is 1.3 for Elixir. I might be able to compile Elixir 1.4 but it might take a while to do it on my machine

ghost commented 7 years ago

Uh oh ... @SimonLab seems like fedora might not be ideal for elixir? Ubuntu might be a solution?

SimonLab commented 7 years ago

I prefer to keep fedora at the moment as I just installed it on my new thinpad x230 :tada: I will use the configuration file for the buildpadk on heroku to select the Elixir version 1.3 and I'm sure 1.4 will be available soon on fedora, see also #45

SimonLab commented 7 years ago

This is now resolved with #44