search

dwyl / dwylbot

:robot: Automating our GitHub Workflow to improve team communication/collaboration and reduce tedious repetition!
28 stars 7 forks source link

Select github data to check #88

Closed SimonLab closed 7 years ago

SimonLab commented 7 years ago

We are currently checking data from a specific issue or pr, this is done in the github api wraper with the get_data function. However depending on the type of the rule the data to check might be different from just an issue or a pr. For example the rule to check for merge conflict on a pr (see #64) needs to get the list of all the open PRs. So instead of creating another case for the get_data function we need to link the type of data we need to get to the error itself. This will allow us to create more complex rule in the future too.

SimonLab commented 7 years ago

This is now resolved. We are still using different case with get_data which is in fact simpler.