search

dwyl / elixir-auth-github

:octocat: Minimalist GitHub OAuth Authentication for Elixir Apps. Tested, Documented & Maintained. Setup in 5 mins. 🚀
GNU General Public License v2.0
38 stars 4 forks source link

Add login_url_with_scopes functions #31

Closed ZooeyMiller closed 7 years ago

ZooeyMiller commented 7 years ago

Rather than change the login_url function, which would be a breaking change for the module as it is, I decided to add in another function to deal with urls with scopes.

It returns a tuple rather than simply a URL because it can error due to a couple of different reasons.

30

codecov[bot] commented 7 years ago

Codecov Report

Merging #31 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #31   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          12     21    +9     
=====================================
+ Hits           12     21    +9
Impacted Files Coverage Δ
lib/elixir_auth_github.ex 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4fbac1c...87e5b6b. Read the comment docs.