search

dwyl / elixir-auth-github

:octocat: Minimalist GitHub OAuth Authentication for Elixir Apps. Tested, Documented & Maintained. Setup in 5 mins. 🚀
GNU General Public License v2.0
38 stars 4 forks source link

Allow `login_url` to have a scope and state as parameters #42

Closed SimonLab closed 4 years ago

SimonLab commented 4 years ago

The current login_url function can be used without any parameters or with a scope parameter:

https://github.com/dwyl/elixir-auth-github/blob/03f390baec154ddbe991671ff90337132ce42e92/lib/elixir_auth_github.ex#L19-L30

I propose that we update the login_url function so it accepts a map containing scope or state or both of the query parameters at the same time.

nelsonic commented 4 years ago

Included in PR #43 and 1.1.0 Published to Hex.pm :shipit: