search

dwyl / elixir-auth-github

:octocat: Minimalist GitHub OAuth Authentication for Elixir Apps. Tested, Documented & Maintained. Setup in 5 mins. 🚀
GNU General Public License v2.0
38 stars 4 forks source link

Get user email when it is set as private on Github #48

Closed SimonLab closed 4 years ago

SimonLab commented 4 years ago

ref: #46 Get the primary email linked to the user's Github account. The /user Github endpoint doesn't provide the user's email if this one is private. We need to send a second request /user/emails to get the list of emails, we then select the primary email from this list.

codecov[bot] commented 4 years ago

Codecov Report

Merging #48 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #48   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           21        29    +8     
=========================================
+ Hits            21        29    +8
Impacted Files Coverage Δ
lib/elixir_auth_github.ex 100.00% <100.00%> (ø)
lib/httpoison_mock.ex 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b92df31...31bab13. Read the comment docs.

nelsonic commented 4 years ago

Looks like we're going to need some tests and a mock response for this. 💭