search

dwyl / elixir-auth-github

:octocat: Minimalist GitHub OAuth Authentication for Elixir Apps. Tested, Documented & Maintained. Setup in 5 mins. πŸš€
GNU General Public License v2.0
38 stars 4 forks source link

Avoid `Mix.env()` issue #51 #58

Closed nelsonic closed 2 years ago

nelsonic commented 2 years ago

This PR is an enhancement to avoid using Mix.env() as it's not available on Fly.io #51

codecov[bot] commented 2 years ago

Codecov Report

Merging #58 (2e6a49c) into main (b9f802d) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #58   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           32        32           
=========================================
  Hits            32        32
Impacted Files Coverage Ξ”
lib/elixir_auth_github.ex 100.00% <100.00%> (ΓΈ)

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update b9f802d...2e6a49c. Read the comment docs.

nelsonic commented 2 years ago

Apologies for the noise. The tests were working OK on my localhost but not on GitHub CI ... πŸ™„

nelsonic commented 2 years ago

@SimonLab please take a look when you can and give feedback / merge. Thanks! πŸ‘

nelsonic commented 2 years ago

Thanks for review and updating to import Config @SimonLab πŸ‘