search

dwyl / elixir-auth-github

:octocat: Minimalist GitHub OAuth Authentication for Elixir Apps. Tested, Documented & Maintained. Setup in 5 mins. πŸš€
GNU General Public License v2.0
38 stars 4 forks source link

Catch-all `HTTPoisonMock.post!` #93

Closed nelsonic closed 1 year ago

nelsonic commented 1 year ago

As outlined in https://github.com/dwyl/elixir-auth-github-demo/issues/29 the tests in the demo app fail because HTTPoisonMock is no longer matching the URL ... πŸ™„ This PR ads a catch-all that ensures the Mocked test passes so the build passes and I don't have to see it fail every time there's a @dependabot update.

codecov[bot] commented 1 year ago

Codecov Report

Merging #93 (c62c19c) into main (483eaef) will not change coverage. Report is 23 commits behind head on main. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #93   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           34        35    +1     
=========================================
+ Hits            34        35    +1
Files Coverage Ξ”
lib/httpoison_mock.ex 100.00% <100.00%> (ΓΈ)

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

nelsonic commented 1 year ago

Totes. πŸ‘Œ