jackcarlisle commented 7 years ago

ready for review after #49 (needs rebase)

[x] changes the show ID from a permalink to ID in the public forum

51

codecov-io commented 7 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@5a68388). Click here to learn what that means. The diff coverage is 100%.

@@           Coverage Diff           @@
##             master    #53   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?     14           
  Lines             ?    146           
  Branches          ?      0           
=======================================
  Hits              ?    146           
  Misses            ?      0           
  Partials          ?      0

Impacted Files	Coverage Δ
test/support/conn_case.ex	`100% <ø> (ø)`
web/router.ex	`100% <ø> (ø)`
web/views/feedback_view.ex	`100% <100%> (ø)`
web/controllers/feedback_controller.ex	`100% <100%> (ø)`
web/models/feedback.ex	`100% <100%> (ø)`
web/controllers/page_controller.ex	`100% <100%> (ø)`
web/controllers/helpers.ex	`100% <100%> (ø)`
web/controllers/session_controller.ex	`100% <100%> (ø)`
web/channels/room_channel.ex	`100% <100%> (ø)`
web/controllers/forum_controller.ex	`100% <100%> (ø)`
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5a68388...8b67a3d. Read the comment docs.

jackcarlisle commented 7 years ago

Closing due to changes in the db that are effecting tests, thus previous branches can't be merged

dwyl / feedback

Forum show #53

ready for review after #49 (needs rebase)

51

Codecov Report