search

dwyl / flutter-bloc-tutorial

A step-by-step example/tutorial explaining the benefits of the BLoC architecture and bloc library including tests!
https://dwyl.github.io/flutter-bloc-tutorial/
GNU General Public License v2.0
67 stars 5 forks source link

[PR] Adding deploy Github Action workflow #5

Closed LuchoTurtle closed 1 year ago

LuchoTurtle commented 1 year ago

closes #4

codecov[bot] commented 1 year ago

Codecov Report

Merging #5 (0792859) into main (fdd1666) will increase coverage by 0.82%. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main        #5      +/-   ##
===========================================
+ Coverage   99.17%   100.00%   +0.82%     
===========================================
  Files           7         7              
  Lines         242       224      -18     
===========================================
- Hits          240       224      -16     
+ Misses          2         0       -2
Impacted Files Coverage Δ
lib/main.dart 100.00% <100.00%> (+1.24%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

LuchoTurtle commented 1 year ago

I've fixed the tests that were failing. Even though the Text and TextFields were responsive, they were gigantic on bigger screens. So I used auto-size-text and auto-size-textfield packages to make the text responsive and wrap properly on smaller screens.

With these changes, I had to fix tests so they'd work.

Additionally, deploying wasn't initially working on the web. This issue was surpassed by looking at stackoverflow.com/questions/74164386/flutter-web-shows-blank-page-on-github-deployment.

LuchoTurtle commented 1 year ago

This should now be able to mergeable now. The link has already been updated on the repo overview page.