search

dwyl / flutter-image-upload-demo

📱🖼️ ⬆️ ☁️ Quick demo Flutter App showcasing uploading images to S3
https://dwyl.github.io/flutter-image-upload-demo/
8 stars 0 forks source link

[PR] Fixing upload to the web and adding Github Pages #4

Closed LuchoTurtle closed 1 year ago

LuchoTurtle commented 1 year ago

closes #3

This PR fixes the image upload behaviour in the web platform, adds tests and also creates a deploy workflow that deploys the web-version of the app to Github Pages.

codecov[bot] commented 1 year ago

Codecov Report

Merging #4 (fc9ee41) into main (8f5654c) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main        #4   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           75        81    +6     
=========================================
+ Hits            75        81    +6
Impacted Files Coverage Δ
lib/http.dart 100.00% <100.00%> (ø)
lib/main.dart 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

LuchoTurtle commented 1 year ago

The file is deployed in https://dwyl.github.io/flutter-image-upload-demo.

However, as mentioned in https://github.com/dwyl/flutter-image-upload-demo/issues/3#issuecomment-1640191103, it won't properly upload an image until https://github.com/dwyl/imgup/pull/101 is merged.