dwyl / flutter-wysiwyg-editor-tutorial

📱📝 How to do WYSIWYG editing in Flutter in 5 easy steps. 🚀
GNU General Public License v2.0
6 stars 0 forks source link

[PR] Switching `ImageButton` with custom button with same behaviour #13

Closed LuchoTurtle closed 1 year ago

LuchoTurtle commented 1 year ago

closes #12

⚠️ Only merge after #11 is merged. ⚠️

This attempts to emulate ImageButton's behaviour with a custom button that does this. The reason we're doing this is described in #12.

codecov[bot] commented 1 year ago

Codecov Report

Merging #13 (bd6325e) into main (a1c14b6) will increase coverage by 21.69%. The diff coverage is 97.67%.

@@             Coverage Diff             @@
##             main      #13       +/-   ##
===========================================
+ Coverage   70.45%   92.14%   +21.69%     
===========================================
  Files           5        6        +1     
  Lines         176      191       +15     
===========================================
+ Hits          124      176       +52     
+ Misses         52       15       -37     
Files Coverage Δ
lib/home_page.dart 91.34% <100.00%> (+13.92%) :arrow_up:
lib/main.dart 100.00% <100.00%> (ø)
lib/web_embeds/web_embeds.dart 80.00% <100.00%> (+72.00%) :arrow_up:
lib/image_button_widget.dart 96.87% <96.87%> (ø)

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

LuchoTurtle commented 1 year ago

This is now ready for review.

Only merge after #11 is merged.

Thanks 🙏

nelsonic commented 1 year ago

11 merged. ✅

nelsonic commented 1 year ago

Merge Button is disabled for me ... 🤷‍♂️

image
LuchoTurtle commented 1 year ago

I've merged main with this branch. May be see if it works now after approving.