dwyl / flutter-wysiwyg-editor-tutorial

πŸ“±πŸ“ How to do WYSIWYG editing in Flutter in 5 easy steps. πŸš€
GNU General Public License v2.0
6 stars 0 forks source link

[PR] Migrating to `visual-editor` #7

Closed LuchoTurtle closed 1 year ago

LuchoTurtle commented 1 year ago

closes #3

This PR migrates the code to visual-editor, using my own fork whilst we wait for the changes to occur in the original repo.

codecov[bot] commented 1 year ago

Codecov Report

Merging #7 (04c2c2c) into main (77bfdc0) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 04c2c2c differs from pull request most recent head 9285206. Consider uploading reports for the commit 9285206 to get more accurate results

@@           Coverage Diff           @@
##             main       #7   +/-   ##
=======================================
  Coverage   67.04%   67.04%           
=======================================
  Files           5        5           
  Lines         176      176           
=======================================
  Hits          118      118           
  Misses         58       58           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

LuchoTurtle commented 1 year ago

This should be reviewable πŸ‘Œ

nelsonic commented 1 year ago

Didn't get the notification for this. Is this reviewable? πŸ’­

image
LuchoTurtle commented 1 year ago

It should be πŸ‘Œ . Again, it's connected to my own fork whilst my PRs aren't yet merged in the original repo. I've included the changes in the merged PR #9 so it doesn't clash.

Should be good to go. WHen the PRs are merged, we can make the changes on a separate PR πŸ‘

nelsonic commented 1 year ago

@LuchoTurtle please transfer the fork to @dwyl so that other people can contribute to it. If we end up having to run our own editor project because the upstream are not merging our PRs then so be it.

LuchoTurtle commented 1 year ago

Let me transfer and make the needed changes, then.

LuchoTurtle commented 1 year ago

You may merge now. I've renamed the folder to alt_visual_editor so people who run flutter run instead from VSCode won't have problems with the naming of the file.

All instances of the old fork have been changed and the repo has been transferred -> https://github.com/dwyl/visual-editor