dwyl / github-backup

:octocat: :back: 🆙 Backup your GitHub Issues so you can still work when (they/you are) offline.
https://github-backup.herokuapp.com
GNU General Public License v2.0
31 stars 3 forks source link

Upgrade to Phoenix version 1.4 #124

Closed RobStallion closed 5 years ago

RobStallion commented 5 years ago

Steps to upgrade can be frond in here

RobStallion commented 5 years ago

Phoenix 1.4 uses Jason in favour of Poison as Chris says in his upgrade guide

Phoenix 1.4 uses Jason for json generation in favor of poison. Poison may still be used, but you must add :poison to your deps to continue using it on 1.4. To use Jason instead, :jason to your deps in mix.exs:

This is not mandatory and as we are using both poison and httpoison in the project I will leave them in the list of deps for the meantime.

These deps are used for storing and retrieving data from S3, something which may not be needed in the future (see #126). If and when we change the way we store data, we can change this step also.

RobStallion commented 5 years ago

Upgrade has gone fine up until Replace Brunch with webpack

When I got to this stage the css in the application did not appear to be loading correctly. All the text sizing was too big. I could not see any errors however so it was not clear what was causing this issue. Having webpack is an optional feature of phoenix 1.4 so I am going to open a separate issue on this and come back to this at a later date.

nelsonic commented 5 years ago

@RobStallion are we using brunch/webpack for anything?

RobStallion commented 5 years ago

At the moment brunch is just being used in the default way all phoenix applications use it.

Copying all static files into priv/static (one css file, the phoenix_html node_module and static assets (images etc))

RobStallion commented 5 years ago

Closing as upgrade has been merged in