dwyl / github-backup

:octocat: :back: 🆙 Backup your GitHub Issues so you can still work when (they/you are) offline.
https://github-backup.herokuapp.com
GNU General Public License v2.0
32 stars 3 forks source link

Add tachyons to the project #22

Closed Cleop closed 6 years ago

Cleop commented 6 years ago
<link rel="stylesheet" href="https://unpkg.com/tachyons@4.6.1/css/tachyons.min.css"/>
SimonLab commented 6 years ago

On a previous project we had some issue getting the css from an external link (a new version of Tachyons was released and the request returned 404 for some time). So I think it might be worth to create the Tachyons minimal file directly into the assets/css directory. We only need to remember to update this file manually if we want another version of Tachyons, we could maybe use npm to automatically fetch the last version of Tachyons and copy it on the assets directory but I don't think at this stage it's necesssary.

At the same time we can remove the phoenix.css file: https://github.com/dwyl/github-backup/blob/initialise-phx-server/assets/css/phoenix.css (which is Bootstrap)

But maybe the external link works fine for a first step :thinking: ?

to read:

Cleop commented 6 years ago

Yeah, I recall this happening on BEP although it was a one off. As the stackoverflow article suggests - we could use the CDN and just specify a given version of Tachyons and that way it won't break.

Alternatively we could use the CDN and resort it to the saved files in the event that it's down as the SO article also says. Although I think that would be an enhancement.

iteles commented 6 years ago

@SimonLab @Cleop Worth adding your experiences above into an issue/FAQ section on the learn-tachyons repo?

nelsonic commented 6 years ago

@Cleop, Are we adding a link to the "learn-tachyons" or can we consider this task done?

Cleop commented 6 years ago

@nelsonic feel free to test by adding a class or simply close as technical 👍

nelsonic commented 6 years ago

@Cleop I'm satisfied that this is done. ✅