search

dwyl / github-backup

:octocat: :back: 🆙 Backup your GitHub Issues so you can still work when (they/you are) offline.
https://github-backup.herokuapp.com
GNU General Public License v2.0
32 stars 3 forks source link

Bug: Comment box not consistent size on Simon's laptop #38

Closed Cleop closed 6 years ago

Cleop commented 6 years ago

image

Cleop commented 6 years ago

The fix for this has been implemented using a precise min-width measurement. Tachyons does not currently have min-width values, see https://github.com/tachyons-css/tachyons/issues/221.

We need a min-width in this instance because using a standard width alone does not work on mobile as the width of the element goes right to the edge of the screen. The reason for this is because the size of the comment part of the element does not fit inside its container because the way it is fitting the avatar in is using margin-left as the avatar is placed using position absolute. As a result this margin is not being accounted for in the width of the item and it is over-spilling its box.

So either we can roll with the precise min-width or we could potentially try flexbox as an alternative.

nelsonic commented 6 years ago

@Cleop this is "fine" for now. @SimonLab please confirm it looks "OK" for you. thanks. 👍

SimonLab commented 6 years ago

@Cleop @nelsonic looks good on my x230 :+1: