dwyl / github-backup

:octocat: :back: πŸ†™ Backup your GitHub Issues so you can still work when (they/you are) offline.
https://github-backup.herokuapp.com
GNU General Public License v2.0
32 stars 3 forks source link

#38 Fixes comment width on wider screens #39

Closed Cleop closed 6 years ago

Cleop commented 6 years ago

38 Fixes comment width on wider screens

codecov[bot] commented 6 years ago

Codecov Report

Merging #39 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #39   +/-   ##
=======================================
  Coverage   95.83%   95.83%           
=======================================
  Files           6        6           
  Lines          24       24           
=======================================
  Hits           23       23           
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 73cafc0...606cce8. Read the comment docs.

Cleop commented 6 years ago

image @nelsonic This is what w-90 gives us on wider screens (like @SimonLab's or my monitor at FocusHub) hence why we ended up with the precise measurement. Normally I'm not a fan either. The only other thing I could try would be flexbox if you think it's worth a shot?

nelsonic commented 6 years ago

@Cleop as long as we capture why we are using an "exact" percentage, for width, it's fine. But perhaps we should inform someone @Tachyons HQ in case it's a bug ... πŸ€”

Cleop commented 6 years ago

https://github.com/tachyons-css/tachyons/issues/221 - technically tachyons doesn't have min-widths at all...

But I can update the issue with more detail πŸ‘

nelsonic commented 6 years ago

Cool. thanks for linking to the issue. πŸ‘ bet you've never had this many comments on a one-line PR. 😜

tachyons commented 6 years ago

I have nothing to do with this project nor @tachyons-css project. Please don't tag me here :-)

nelsonic commented 6 years ago

Yeah, sorry ... I did not mean to incorrectly tag you. πŸ€¦β€β™‚οΈ bet you get a lot of that ... having a similar username to a super-popular project ... πŸ™„ Won't happen again (at least not from us!) πŸ‘

tachyons commented 6 years ago

No issues, just pinged to potentially avoid this in future :-). This is not first time I am getting notifications due to this typo