Closed Cleop closed 6 years ago
Merging #39 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #39 +/- ##
=======================================
Coverage 95.83% 95.83%
=======================================
Files 6 6
Lines 24 24
=======================================
Hits 23 23
Misses 1 1
Continue to review full report at Codecov.
Legend - Click here to learn more
Ξ = absolute <relative> (impact)
,ΓΈ = not affected
,? = missing data
Powered by Codecov. Last update 73cafc0...606cce8. Read the comment docs.
@nelsonic This is what w-90 gives us on wider screens (like @SimonLab's or my monitor at FocusHub) hence why we ended up with the precise measurement. Normally I'm not a fan either. The only other thing I could try would be flexbox if you think it's worth a shot?
@Cleop as long as we capture why we are using an "exact" percentage, for width, it's fine.
But perhaps we should inform someone @Tachyons HQ in case
it's a bug
... π€
https://github.com/tachyons-css/tachyons/issues/221 - technically tachyons doesn't have min-widths at all...
But I can update the issue with more detail π
Cool. thanks for linking to the issue. π
bet you've never had this
many comments on a one-line PR. π
I have nothing to do with this project nor @tachyons-css project. Please don't tag me here :-)
Yeah, sorry ... I did not mean to incorrectly tag you. π€¦ββοΈ bet you get a lot of that ... having a similar username to a super-popular project ... π Won't happen again (at least not from us!) π
No issues, just pinged to potentially avoid this in future :-). This is not first time I am getting notifications due to this typo
38 Fixes comment width on wider screens