Connect staging with github app to receive webhooks

dwyl / github-backup

:octocat: :back: 🆙 Backup your GitHub Issues so you can still work when (they/you are) offline.

https://github-backup.herokuapp.com

GNU General Public License v2.0

32 stars 3 forks source link

Connect staging with github app to receive webhooks #63

Open Cleop opened 6 years ago

Cleop commented 6 years ago

Currently we don't have any data on the heroku staging site because our github app webhook url is targeted on our ngrok url for localhost.

@SimonLab informs me that for the dwylbot github app he created 'dwylbot' as a new github user and then pointed the app created on the 'dwylbot' account to the staging url.

I can think of a couple of options to set up staging with data:

We could create a new account as @SimonLab did before specifically for gh-backup
or we could create a generic 'dwyl' account that we can use for future instances like this so that we don't have to create a new account each time
or we could set this app up on dwylbot (or change the name of the dwylbot user if that's possible? but then would messages no longer appear as if they were written by 'dwylbot'?)
or we could create a second github app on my account and point that one at staging

@nelsonic - do you have any thoughts on this?

nelsonic commented 6 years ago

@Cleop please link staging to this repo. 😮

Cleop commented 6 years ago

@nelsonic - I mean for the creation of the 'github app', you have to create a 'github app' in your dev settings as a user rather than attaching it to a repo. Does that make sense?

Cleop commented 6 years ago

We also need a new user because: https://github.com/dwyl/github-backup/issues/14#issuecomment-371786848

When we count the number of edits to a comment and then update (edit) the comment meta table to reflect this we will get stuck in an infinite loop unless we filter out the actions of the app by user, giving the app a distinctive user whose actions won't be counted.

nelsonic commented 6 years ago

@Cleop https://github.com/gibuio related to #13 (CC: @iteles should we register the "gibu.io" domain?)

iteles commented 6 years ago

Replied on the name in that issue!

SimonLab commented 6 years ago

@nelsonic @iteles is https://github.com/gitbuco ours? Also we might want to create two different Github apps one for staging and one for production like this the features tested on staging won't "break" any repositories (ex: adding another meta table on the description of the issues) which are also linked to the production app

Cleop commented 6 years ago

external-dependency label added as we're awaiting the login details for the user account.