search

dwyl / github-backup

:octocat: :back: 🆙 Backup your GitHub Issues so you can still work when (they/you are) offline.
https://github-backup.herokuapp.com
GNU General Public License v2.0
32 stars 3 forks source link

Display checkboxes correctly as checkboxes #69

Closed Cleop closed 6 years ago

Cleop commented 6 years ago

Currently checkboxes display like this: image when they should display like this:

Relates #53

As a user I want to be able to see the UI I am accustomed to on github So that I can easily understand the comments I am reading.

This has been created as a separate issue so that it can be prioritised separately.

SimonLab commented 6 years ago

This is linked to Github Flavored Markdown: https://guides.github.com/features/mastering-markdown/#GitHub-flavored-markdown

Cleop commented 6 years ago

Earmark only currently partially supports GFM and this does not include checkboxes/task lists: https://github.com/pragdave/earmark/issues/126

I have however found in the options how to support line breaking.

I'm going to write a custom fn to display the input boxes. I've tested this using html inside the github comment and it worked. So now I'm going to try and implement it.

This has however made me aware of another issue which is that, at present, we are vulnerable to script attacks, I've created #95 for this.

nelsonic commented 6 years ago

@Cleop great work! 🎉