search

dwyl / gogs-server

⚙️ CI/CD Pipeline + Docs for our Gogs Server on Fly.io
https://gogs-server.fly.dev/
GNU General Public License v2.0
3 stars 0 forks source link

Using image vs fly.toml for launching app #1

Open SimonLab opened 2 years ago

SimonLab commented 2 years ago

On the create an app section we have the following command:

flyctl launch --name gogs-server --image gogs/gogs --org dwyl

This will create a new Fly app with the gogs image, (I guess from https://hub.docker.com/r/gogs/gogs). However the fly.tomlalso contains in the build section the gogs image: https://github.com/dwyl/gogs-server/blob/5e434c77823de8240e761ea938cf4d16c57870cb/fly.toml#L12-L13

So could we instead of using the --image gogs/gogs flag, just run

flyctl launch --name gogs-server --org dwyl

We could also not pass the --org flag and let the command line ask later on the launch step I think.

nelsonic commented 2 years ago

@SimonLab yeah, I was just building it from first principals as if the fly.toml file didn't exist. ✍️ But yeah, we could update the docs to the command you suggest now that the file is there. 💭