Error doesn't fail the pre commit hook

dwyl / goodparts

:see_no_evil: An ESLint Style that only allows JavaScript the Good Parts (and "Better Parts") in your code.

GNU General Public License v2.0

78 stars 26 forks source link

Error doesn't fail the pre commit hook #268

Closed jay-meister closed 7 years ago

jay-meister commented 7 years ago

Using module pre-commit, the "lint": "path/to/files" script, and the "pre-commit": ["lint"] added to our package.json, I can commit a file that fails the linting check.

The error is printed to the console, but the file is still committed.

Perhaps some documentation/example of a pre commit hook in action if you have one?

SimonLab commented 7 years ago

@JMurphyWeb I think it's a duplicate now see #266 and it is now resolved (thanks @eliascodes ) with this PR #267

jay-meister commented 7 years ago

Fair dos. Could add a little line to the readme.. I am happy to do this when I have it working.

nelsonic commented 7 years ago

@JMurphyWeb thanks for reporting this! (and thanks @eliascodes for fixing it!) ❤️ ✅ Please confirm it's working as expected then close the issue. 👍

jay-meister commented 7 years ago

Seems to be working. I will make PR with README addition.