search

dwyl / goodparts

:see_no_evil: An ESLint Style that only allows JavaScript the Good Parts (and "Better Parts") in your code.
GNU General Public License v2.0
78 stars 26 forks source link

Update README.md #276

Closed Jbarget closed 7 years ago

nelsonic commented 7 years ago

this PR only "fails" because of https://github.com/dwyl/goodparts/issues/274 which is fixed in my PR: #273 😉

Jbarget commented 7 years ago

fab fab, no worries :)

nelsonic commented 7 years ago

@Jbarget I wasn't suggesting we close your PR... 😢 I was actually suggesting you grab the code from: rules/es6.js and test/fixtures/es6.js in this commit: https://github.com/dwyl/goodparts/pull/273/files#diff-f92ae6e935255e90991a27ce10091994 so your PR will pass and we can merge it...! 👍

Please re-open it so we can get that typo fixed asap as I have no idea when my PR will be ready... thanks! ❤️

nelsonic commented 7 years ago

@Jbarget thanks for fixing that typo and adding the 'no-return-await': 'off' rule. 👍

Jbarget commented 7 years ago

whoops sorry, my process has been lacking:

fixes https://github.com/dwyl/goodparts/issues/274

nelsonic commented 7 years ago

@Jbarget it's fine. 👍