search

dwyl / goodparts

:see_no_evil: An ESLint Style that only allows JavaScript the Good Parts (and "Better Parts") in your code.
GNU General Public License v2.0
78 stars 26 forks source link

Should we default to disabling a rule? #281

Open nelsonic opened 7 years ago

nelsonic commented 7 years ago

Each time the eslint package adds a rule goodparts CI "fails" unnecessarily... e.g: https://travis-ci.org/dwyl/goodparts/builds/196241118#L698

could/should we default to disabling a rule if it's "not configured" to avoid this...? I was trying to add a CONTRIBUTING.md file in: https://github.com/dwyl/goodparts/pull/280 but could not because the build fails... 😞

thoughts?

varjmes commented 7 years ago

I would pass the test suite if a rule is not configured. I'd still want to know there was an error, but I wouldn't want to fail the build.

samhstn commented 7 years ago

Could we just change the package.json eslint version from

"eslint": "^3.9.1",

to

"eslint": "~3.9.1",

And then let david-dm notify us of new eslint releases which we can address separately.

Would that work?

I feel that just having the ci log that we have unaddressed rules will get ignored.

@nelsonic @Charlotteis Totally fine with not doing this if you think disabling the new rules would be better

varjmes commented 7 years ago

I think greenkeeper could let us know of new releases, by PRing updates to node packages which we could address?

nelsonic commented 7 years ago

Does Greenkeeper still require "admin access" to all repos in the Org to do it's thing? 🤔 see: https://github.com/dwyl/hq/issues/100 😕

varjmes commented 7 years ago

@nelsonic https://github.com/integration/greenkeeper :)

nelsonic commented 7 years ago

@Charlotteis thanks for updating our knowledge on Greenkeeper. 👍 Greenkeeper Permissions (no longer admin access...)

Fl4m3Ph03n1x commented 7 years ago

I was moved here via thread https://github.com/dwyl/goodparts/issues/272#issuecomment-310834719

I see this issues was closed, is any assistance still needed?

nelsonic commented 7 years ago

@Fl4m3Ph03n1x yes, we need to default to ignoring new rules. if you have time to implement, please go for it! 👍

Fl4m3Ph03n1x commented 7 years ago

@nelsonic I tried to find the time, but unfortunately I just can't dedicate it. I apologize for not being more useful, but at least I will try to help on what I can.

nelsonic commented 7 years ago

@Fl4m3Ph03n1x never apologise for not having "enough time" that's the human condition. ⌛️ you've made great contributions already and we're super grateful! 🎉