dwyl / goodparts

:see_no_evil: An ESLint Style that only allows JavaScript the Good Parts (and "Better Parts") in your code.
GNU General Public License v2.0
78 stars 26 forks source link

adding support of goodparts for eslint and prettier users #285

Open 92arpitgoyal opened 5 years ago

92arpitgoyal commented 5 years ago

Hi,

I think it a general issue when a project is already using eslint and/or prettier for linting/styling and don't want to remove them but, want to integrate goodparts.

We can we add a basic info in docs on how to extend existing *rc files to follow goodparts.

So, the idea is to create a repo and a module like https://www.npmjs.com/package/eslint-config-airbnb and whatever equivalent there is for prettier which users can extend and use.

and obviously add it in docs of https://github.com/dwyl/goodparts

92arpitgoyal commented 5 years ago

Initial discussions at #53 and #5

nelsonic commented 5 years ago

@92arpitgoyal this would be a great addition/enhancement! 🥇 if you have time please create a Pull Request! 🎉

92arpitgoyal commented 5 years ago

Thanks @nelsonic

I have started with https://github.com/92arpitgoyal/eslint-config-goodparts and https://www.npmjs.com/package/eslint-config-goodparts

Am I going in right direction?

nelsonic commented 5 years ago

@92arpitgoyal the repo you have created looks promising. We found that the most time-consuming part was writing the tests.

92arpitgoyal commented 5 years ago

Thanks @nelsonic I will work on testing, can you suggest something for starters? I am new to writing test cases.

nelsonic commented 5 years ago

@92arpitgoyal consider taking a look at the tests that @rjans/@eliascodes wrote for this repo! They are exemplary of a testing system rather than attempting to write tests individually. 🥇

92arpitgoyal commented 5 years ago

I went through the code, it is using tape as it's framework for testing, will try it and update the codebase.

nelsonic commented 5 years ago

@92arpitgoyal have you had a look at https://github.com/dwyl/learn-tape ?