Istanbul is deprecated, migrate to NYC

dwyl / goodparts

:see_no_evil: An ESLint Style that only allows JavaScript the Good Parts (and "Better Parts") in your code.

GNU General Public License v2.0

78 stars 26 forks source link

Istanbul is deprecated, migrate to NYC #286

Closed oleg-koval closed 5 years ago

oleg-koval commented 5 years ago

During npm install i receive this:

This module is no longer maintained, try this instead: npm i nyc Visit https://istanbul.js.org/integrations for other alternatives.

Also package-lock.json is missing.

I already have a branch with following migration, if its needed I can open a PR

nelsonic commented 5 years ago

Hi @oleg-koval thank you for opening this issue! If you have already done the work, please PR the change from istanbul to nyc 👍 (we are aware of it and it's on our list of things to update: https://github.com/dwyl/learn-istanbul/issues/20 ...) Our reasoning for leaving the package-lock.json file out of version control is that it creates a lot of noise whenever something is updated (without much benefit to the users) ...

oleg-koval commented 5 years ago

@nelsonic I understand your concern about package-lock