search

dwyl / hapi-auth-github

:octocat: GitHub Authentication Plugin for Hapi.js Apps Quick/Easy/Secure/Tested
GNU General Public License v2.0
17 stars 3 forks source link

make redirect url be configurable by .env #21

Closed jrans closed 8 years ago

jrans commented 8 years ago

discussion about this in #14

very simple change, updates to example, readme and most importantly code to use env variable to set redirect url.

When we republish this will be a breaking change. So need to to choose the correct version number...

Resolves #14

codecov-io commented 8 years ago

Current coverage is 100% (diff: 100%)

Merging #21 into master will decrease coverage by 0.00%

@@           master   #21   diff @@
===================================
  Files           4     4          
  Lines          81    81          
  Methods         0     0          
  Messages        0     0          
  Branches        0     0          
===================================
  Hits           81    81          
  Misses          0     0          
  Partials        0     0

Powered by Codecov. Last update f22f3bd...1336fbe

nelsonic commented 8 years ago

@jrans thanks very much for updating this. 👍