search

dwyl / hapi-auth-google

:lollipop: Let people authenticate with your application/website using their Google Account (OAuth2)
GNU General Public License v2.0
41 stars 6 forks source link

Hapi v17 Compatibility #51

Open Y-LyN-10 opened 7 years ago

Y-LyN-10 commented 7 years ago

Hapi v17 will be released very soon. It introduces a lot of breaking changes and probably no current plugin will work anymore. Unfortunately that's the case for hapi-auth-google as well and it's not possible to make it backwards-compatible (new hapi plugin API docs).

I have experimented a little bit in my fork to make it work with the latest version of Hapi ("17.0.0-rc9", but nodejs >= v8.x.x is required as well).

I am wondering how are we going to proceed with this in future? Will there be two distinct releases? Should I create a new branch or hold it for now?

I would be glad if we can discuss everything regarding to v17 in this thread. Thanks.

nelsonic commented 7 years ago

@Y-LyN-10 indeed Hapi v17 has fundamentally changed how Plugins work ... 😞 We are waiting for the Release (Upgrade Path) Notes to be finalised before doing any work on this: https://github.com/hapijs/hapi/issues/3658 But if you have already made a start at migrating against the "Release Candidate" that's awesome! 👍

Y-LyN-10 commented 7 years ago

Yes, I am waiting for the final release too: just in case there are more breaking changes :smile: Currently I have a working (read: needs improvement) version of this library with updated example and tests (passing, yay) with Hapi v17.0.0-rc9. I would be hapi to contribute here! ^_^

Y-LyN-10 commented 7 years ago

@nelsonic, a new branch is created: hapi17-compatible. What should I do now? :thinking:

nelsonic commented 7 years ago

If you create a PR based on this branch Codecov should pass. 👍

Y-LyN-10 commented 7 years ago

Just to clarify: PR to merge hapi17-compatible branch into ... master? :innocent:

nelsonic commented 7 years ago

@Y-LyN-10 Yeah, the PR should be into master thanks!