dwyl / hapi-auth-jwt2

:lock: Secure Hapi.js authentication plugin using JSON Web Tokens (JWT) in Headers, URL or Cookies

ISC License

798 stars 126 forks source link

Hapi v19 returns HTTP Status Code 204 "no content" #339

Closed nelsonic closed 4 years ago

nelsonic commented 4 years ago

Hapi v.19 has introduced more precise HTTP status codes 204 ("no content"): https://travis-ci.org/dwyl/hapi-auth-jwt2/jobs/647655247#L228

This is correct because the example server being tested is not returning any content. https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/204

https://github.com/dwyl/hapi-auth-jwt2/blob/e48fd6812aac7a6cb3e7454fd8e622fedd5aa7f1/test/error_func.test.js#L7-L16

https://github.com/dwyl/hapi-auth-jwt2/blob/e48fd6812aac7a6cb3e7454fd8e622fedd5aa7f1/test/error_func_server.js#L10-L12

Todo

[x] update the tests for sendToken function to assert the more accurate HTTP status code.
[x] re-run the tests and confirm 204 status code is returned.

nelsonic commented 4 years ago

update to test assertions included in #337