dwyl / hapi-auth-jwt2

:lock: Secure Hapi.js authentication plugin using JSON Web Tokens (JWT) in Headers, URL or Cookies

ISC License

798 stars 126 forks source link

Update devDependencies #346

Open nelsonic opened 4 years ago

nelsonic commented 4 years ago

https://david-dm.org/dwyl/hapi-auth-jwt2?type=dev

Todo

[ ] update versions of prettier and tape see: https://github.com/dwyl/learn-tape/pull/45
[ ] re-run tests to confirm everything still works
[ ] create PR.

aditya2499 commented 4 years ago

I am new to open source community. Can I take this issue?

nelsonic commented 4 years ago

Hi @aditya2499! Welcome to dwyl! 👋 Really appreciate the offer of updating these devDependencies. If you have experience with Hapi.js and Tape please go for it. 👍 I tried yesterday, but updating Tape to the latest version broke a few tests. 😞

aditya2499 commented 4 years ago

I updated the version of both the modules and all tests passed. Have a look #347

nelsonic commented 4 years ago

@aditya2499 please see: https://travis-ci.org/github/dwyl/hapi-auth-jwt2/jobs/680588777#L236 Sadly, for some reason the Tests fail. 😞