search

dwyl / hapi-postgres-connection

:zap: Creates a PostgreSQL Connection (Pool) available anywhere in your Hapi App
GNU General Public License v2.0
40 stars 13 forks source link

node pg upgrade #27 #28

Closed naazy closed 7 years ago

naazy commented 7 years ago

node pg upgrade #27 as per https://node-postgres.com/guides/upgrading

codecov[bot] commented 7 years ago

Codecov Report

Merging #28 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #28   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          31     32    +1     
=====================================
+ Hits           31     32    +1
Impacted Files Coverage Δ
index.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c416c57...4fb0717. Read the comment docs.

Jbarget commented 7 years ago

@naazy its talkin' about this line: https://github.com/dwyl/hapi-postgres-connection/blob/pgConnectDegradation/test/server_example.js#L49

apparently result is undefined

naazy commented 7 years ago

Thanks @Jbarget will look into this later

naazy commented 7 years ago

@nelsonic have upped node-pg and changed the version of this module to 6.2.0

nelsonic commented 7 years ago

@naazy latest version hapi-postgres-connection@6.2.0 is on NPM! Thanks again for making time to do these updates! 🎉