search

dwyl / hapi-postgres-connection

:zap: Creates a PostgreSQL Connection (Pool) available anywhere in your Hapi App
GNU General Public License v2.0
40 stars 13 forks source link

Add the option of connecting using SSL #35

Closed alina-dumitrache closed 6 years ago

alina-dumitrache commented 6 years ago

Add the ability of setting DATABASE_SSL environment variable to true for establishing a connection using SSL.

This will potentially fix https://github.com/dwyl/hapi-postgres-connection/issues/34, I was getting the same error and the fix worked for me.

codecov[bot] commented 6 years ago

Codecov Report

Merging #35 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #35   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          33     33           
=====================================
  Hits           33     33
Impacted Files Coverage Δ
index.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6017119...99ee27d. Read the comment docs.

alina-dumitrache commented 6 years ago

@nelsonic Would you please have a look and advise if this change can be merged? Thanks in advance.

alina-dumitrache commented 6 years ago

@nelsonic Thanks for approving and for the great libraries you are creating. Good luck moving forward! 🥇