dwyl / hapi-socketio-redis-chat-example

:speech_balloon: Real-time Chat using Hapi.js + Socket.io + Redis Pub/Sub (example with tests!!)
GNU General Public License v2.0
364 stars 73 forks source link

Improved mobile layout for smaller devices #76

Closed yurm04 closed 7 years ago

yurm04 commented 7 years ago

This pull request addresses Issue https://github.com/dwyl/hapi-socketio-redis-chat-example/issues/31 and includes:

Small Device mobile-small

Medium Device mobile-med

codecov-io commented 7 years ago

Current coverage is 100% (diff: 100%)

Merging #76 into master will not change coverage

@@           master   #76   diff @@
===================================
  Files           3     3          
  Lines          52    52          
  Methods         0     0          
  Messages        0     0          
  Branches        0     0          
===================================
  Hits           52    52          
  Misses          0     0          
  Partials        0     0          

Powered by Codecov. Last update da1ba39...9d0f2e7

iteles commented 7 years ago

Will review at lunch 👍 Thanks for the PR @yurm04 , would also be great to know how you found dwyl! 😊

yurm04 commented 7 years ago

@iteles @nelsonic thank you both 😄 I found the project while searching for a Hapi.js/socket.io implementation as research for a similar project I'm working on. I'm new to Hapi, so this was perfect to get me started in the right direction. The inclusion of Redis was a plus since I was kicking around different ideas for storage, but now I'm sold on this particular setup.

Would love to keep contributing to the project so if there are any other issues/requests I can help with, please shoot them my way!

iteles commented 7 years ago

@yurm04 This is fantastic, thank you! ❤️ Super impressed with the organisation and quality of your code, clear commit and PR messages.

I've only suggested one action in the comments above which is not a blocker for merging this in :tada:

Welcome to dwyl!