dwyl / hits-elixir

:chart_with_upwards_trend: An Elixir implementation of the "Hits" project (a super-basic "Web Page View Counter")

http://hits.dwyl.io

GNU General Public License v2.0

31 stars 1 forks source link

Fix Failing Travis-CI Build (Compilation Warnings) #19

Open nelsonic opened 6 years ago

nelsonic commented 6 years ago

At present the Traivs-CI build is failing because we are treating compilation warnings as "errors": https://travis-ci.org/dwyl/hits-elixir/builds/341144484#L771

Todo

[ ] go through all the compilation warnings and fix the ones that are under our control. (e.g we cannot "fix" the ones in lib/plug/adapters/cowboy.ex:220 but anything local to our project)

samhstn commented 6 years ago

We should actually be running compile --warnings-as-errors. The command does not exit with a non 0 exit code if third party libraries produce warnings.

I checked out to the previous state of that travis build:

git checkout 7cee84a74047453dc27dc063b177992bd7784467

when running:

mix compile --warnings-as-errors

I did get echo $? # returning 1 status code

But if you read our errors and fix them, then

mix compile --warnings-as-errors && echo $? # returns 0