search

dwyl / hits-elixir

:chart_with_upwards_trend: An Elixir implementation of the "Hits" project (a super-basic "Web Page View Counter")
http://hits.dwyl.io
GNU General Public License v2.0
31 stars 1 forks source link

Simplify coverage commands #24

Closed samhstn closed 6 years ago

samhstn commented 6 years ago

What we could change:

In the README we currently have:

MIX_ENV=test mix do coveralls.json

I would suggest that this should be:

mix cover

We also have:

MIX_ENV=test mix coveralls.html && open cover/excoveralls.html

I would suggest that this should be:

mix cover.html && open cover/excoveralls.html

Why this should be changed

In our mix.exs file we already specify that the preferred MIX_ENV is test for these commands, so we should remove MIX_ENV=test

I would quite like making use of the aliases, that way we can just update the aliases instead of documentation when we decide to expand what cover would do (for instance) (and it makes for a nicer developer experience when setting up the project).

nelsonic commented 6 years ago

@shouston3 agreed. go for it! 👍

nelsonic commented 6 years ago

Fixed by @shouston3 🎉 closing.