Closed ndrean closed 3 months ago
Attention: Patch coverage is 98.61111%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 99.62%. Comparing base (
c9985ba
) to head (f71e829
). Report is 6 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
lib/app_web/live/page_live.ex | 96.87% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Doing this with JS is so easy compared to a LV version, and uses the server for nothing, so I do fully agree. It was most to show what is possible, epecially in terms of testing the UI. But I failed on this last bit, and note that the JS part is not tested neither 🤷♂️
You're completely right! And I thank you for showing me because your way is definitely the best for UX! I just personally want to keep it really, really simple for the end-user and want this repo to be focused on the ML part of the things = D
You can find an example of tabs in this PR.
You have a navigation bar (primitive, as a demo).
On mount, it loads the "Image" component. The navigation is essentially captured in a
handle_params
and toggles the attributestyle="display: none/block;"
set on the "Image" page and the "Audio" page.I failed to test this.
Floki
doesn't read thestyle
attribute. I triedWallaby
. When I run only the current tests, it produces errors, so seems incompatible, or my settings are incorrect. When I run only on the new tests to check the navigation, I have a failure.