dwyl / image-classifier

🖼️ Classify images and extract data from or describe their contents using machine learning
GNU General Public License v2.0
18 stars 3 forks source link

Tabs #77

Closed ndrean closed 3 months ago

ndrean commented 4 months ago

You can find an example of tabs in this PR.

You have a navigation bar (primitive, as a demo).

I also I just saw you pushed a better HTML so it might not be up to your standards :)

On mount, it loads the "Image" component. The navigation is essentially captured in a handle_params and toggles the attribute style="display: none/block;" set on the "Image" page and the "Audio" page.

I failed to test this. Flokidoesn't read the style attribute. I tried Wallaby. When I run only the current tests, it produces errors, so seems incompatible, or my settings are incorrect. When I run only on the new tests to check the navigation, I have a failure.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 98.61111% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 99.62%. Comparing base (c9985ba) to head (f71e829). Report is 6 commits behind head on main.

Files Patch % Lines
lib/app_web/live/page_live.ex 96.87% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #77 +/- ## =========================================== - Coverage 100.00% 99.62% -0.38% =========================================== Files 5 9 +4 Lines 198 269 +71 =========================================== + Hits 198 268 +70 - Misses 0 1 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ndrean commented 3 months ago

Doing this with JS is so easy compared to a LV version, and uses the server for nothing, so I do fully agree. It was most to show what is possible, epecially in terms of testing the UI. But I failed on this last bit, and note that the JS part is not tested neither 🤷‍♂️

LuchoTurtle commented 3 months ago

You're completely right! And I thank you for showing me because your way is definitely the best for UX! I just personally want to keep it really, really simple for the end-user and want this repo to be focused on the ML part of the things = D