dwyl / image-classifier

🖼️ Classify images and extract data from or describe their contents using machine learning
GNU General Public License v2.0
18 stars 3 forks source link

separate folder for hnswlib #93

Closed ndrean closed 3 months ago

ndrean commented 3 months ago

To further clean the main Readme, I propose to create a separate folder "hnswlib" and reference it in the main README.

It contains:

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (3ce0c0d) to head (4850019).

:exclamation: Current head 4850019 differs from pull request most recent head 4a4413b. Consider uploading reports for the commit 4a4413b to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #93 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 5 5 Lines 199 199 ========================================= Hits 199 199 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ndrean commented 3 months ago

Did I??? The second time? I hardly touched the main README, did not use mix format if this is what you mean, only saved after removing a paragraph. I synced the fork and git pulled the repo locally. After checking, I see the changes below but I did not changed it!!!

Screenshot 2024-03-24 at 17 38 54

nor did I changed any of all the followings!!!

Screenshot 2024-03-24 at 17 41 07

But indeed when I look at my code, it is formatted as shown. For example, I see this change:

Screenshot 2024-03-24 at 17 45 51

So what could be the settings I have/use to make this happen?

LuchoTurtle commented 3 months ago

@ndrean I have a feeling you're using VSCode and it's saving automatically. When saved automatically, it perhaps formats the README. :P

Before committing your code, maybe check when the changes are being made. That way you know if your IDE is pulling your leg haha.

But yeah, if you could just revert those partial changes in the README, I'll merge this straight away!

LuchoTurtle commented 3 months ago

Looks good, thanks!