dwyl / learn-elixir

:droplet: Learn the Elixir programming language to build functional, fast, scalable and maintainable web applications!
1.62k stars 109 forks source link

Code reuse publishing to hexpm issue #95 #146

Closed nelsonic closed 2 years ago

nelsonic commented 4 years ago

The purpose of this PR is to show a real world example for re-using code ... #95 ♻️ It's not "finished" but it already contains a lot of useful info so I think it's worth merging. πŸ’­ We can extend it when life is a bit less hectic. 🀞

codecov[bot] commented 4 years ago

Codecov Report

Merging #146 (fa71157) into master (9de32c6) will not change coverage. The diff coverage is n/a.

:exclamation: Current head fa71157 differs from pull request most recent head 7f9e2ff. Consider uploading reports for the commit 7f9e2ff to get more accurate results

@@            Coverage Diff            @@
##            master      #146   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            3         3           
=========================================
  Hits             3         3           

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 9de32c6...7f9e2ff. Read the comment docs.

nelsonic commented 4 years ago

Read: /code-reuse-hexpm.md

nelsonic commented 2 years ago

~~This PR is not "finished" but it already contains a lot of useful stuff. So I figure we should just merge this as-is and extend it when we have time.~~

I tidied it up and it's reviewable / mergeable in it's current state. πŸ™

nelsonic commented 2 years ago

@SimonLab this is totally not urgent. Defo focus on your work-work first. πŸ‘ It will be useful to people learning Elixir so keen to publish at some point. :shipit: Thanks.

nelsonic commented 2 years ago

@SimonLab when you have T25m please read through this and provide feedback. πŸ‘

nelsonic commented 2 years ago

Thank you for reading it with a close eye and making all the typo-fixes, Simon! πŸ™Œ πŸš€