Tests won't load on local filesystem

dwyl / learn-elm-architecture-in-javascript

:unicorn: Learn how to build web apps using the Elm Architecture in "vanilla" JavaScript (step-by-step TDD tutorial)!

https://todomvc-app.herokuapp.com

GNU General Public License v2.0

212 stars 19 forks source link

Tests won't load on local filesystem #25

Closed macintoshhelper closed 7 years ago

macintoshhelper commented 7 years ago

GET file://code.jquery.com/qunit/qunit-1.18.0.css net::ERR_FILE_NOT_FOUND error is given if loading the test html page from local file system (not from a live-server).

This is because // is used in the script sources which will use file:// instead of http://.

https:// could be used instead of //.

<script src="https://code.jquery.com/qunit/qunit-1.18.0.js"></script>

instead of //code.jquery...

nelsonic commented 7 years ago

@macintoshhelper thank you very much for reporting this issue! ❤️ Do you have time to send us a Pull Request fixing it?

macintoshhelper commented 7 years ago

Fixed with #26 :)

nelsonic commented 7 years ago

@macintoshhelper thanks again! 🎉