search

dwyl / learn-elm-architecture-in-javascript

:unicorn: Learn how to build web apps using the Elm Architecture in "vanilla" JavaScript (step-by-step TDD tutorial)!
https://todomvc-app.herokuapp.com
GNU General Public License v2.0
212 stars 19 forks source link

Gif on line 169 of README needs updating #62

Closed iteles closed 6 years ago

iteles commented 6 years ago

The gif on line https://github.com/dwyl/learn-elm-architecture-in-javascript/blame/master/README.md#L169 of the README needs to be updated to remove model and replace this with just the initial value.

0-without-model-for-initial-value

Having the word model there means the app doesn't work.

@nelsonic Which gif-making app do you recommend for the change?

nelsonic commented 6 years ago

@iteles I didn't use a gif-making-app at all. just took screenshots or videos and uploaded to http://gifmaker.me

But I'm considering using Scrimba to re-do the tutorial so people can follow along more interactively.

iteles commented 6 years ago

In the meantime, updating this gif (this isn't amazing, but this was my 3rd try, I don't know how you made the original so perfect!):

elm-architecture-counter-mount-update

nelsonic commented 6 years ago

@iteles did you make a PR with the updated GiF? (are you able to check how big the file is?)

iteles commented 6 years ago

I haven't made the PR yet but the gif was 37kb on my computer!

nelsonic commented 6 years ago

37Kb is good. ship it! :shipit: