search

dwyl / learn-flutter

🦋 Learn how to use Flutter to Build Cross-platform Native Mobile Apps
https://flutter.dev
GNU General Public License v2.0
73 stars 8 forks source link

Adding information about Flutter and the utility #24

Closed miguelmartins17 closed 4 years ago

miguelmartins17 commented 4 years ago

I've added some topics like why you should use/learn Flutter , the core principles and how widgets work. I hope it helps and that it can improve the repository. 👍

miguelmartins17 commented 4 years ago

@nelsonic When you have time please if you can review this 👍

nelsonic commented 4 years ago

@miguelmartins17 when you feel you have finished working on the PR, please assign it to me and update the label from in-progress to awaiting-review. See: https://github.com/dwyl/contributing#step-3-prepare-a-pull-request-pr-and-assign-to-someone-else-for-review

nelsonic commented 4 years ago

@miguelmartins17 the PR is still assigned to you ... image

The reason we update the assignee is so that it's clear who's "turn" it is. In the past we have had instances where reviewer is reviewing the code and the author pushes up a change that invalidates the reviewer's efforts which is a huge waste of time. That's review only starts when the PR is assigned to the reviewer.

nelsonic commented 4 years ago

To be clear: the reason I left a comment on the PR yesterday before it was assigned to me for review. Was that I wanted to help you avoid copy-pasting directly from the Flutter docs. Copy-pasting is the equivalent of you ordering a takeaway from PizzaHut and saying you "cooked" it. 🙄

miguelmartins17 commented 4 years ago

@nelsonic So is it necessary to change the Assignees for you ? 😕

nelsonic commented 4 years ago

Miguel, if you it's too much effort for you to follow a systematic approach, please let me know. 👍 Everyone else accepts that our workflow is to assign a Pull Request. Are you special?

miguelmartins17 commented 4 years ago

@nelsonic Of course, I didn't even say anything like that, I just didn't understand if you're supposed to be Assignee.

miguelmartins17 commented 4 years ago

@nelsonic In case you didn't realize my approach was in a tone of doubt not in a tone of thinking it is a strange method.

nelsonic commented 4 years ago

Miguel, what you're saying is that you didn't read the instructions or link I shared above. https://github.com/dwyl/learn-flutter/pull/24#issuecomment-583727191 ⬆️ image

read-the-contributing-guide

Reading the contributing guide is a requirement ... https://github.com/dwyl/apprenticeship#prerequisites apprenticeship-prerequisites

I'm not trying to be difficult, I just want you to understand that every company/organisation has a "workflow" for getting work done. Most software companies are a lot more tedious than ours. 👍

miguelmartins17 commented 4 years ago

@nelsonic I read it now and I understand what you mean. I thought as a reviewer it was right for you to do the Pull Request review.

Obviously I wasn't going to merge the text I was trying to add without someone doing the review first, I already had wrong before. I'm sorry. I understand your very methodical workflow that it's right to be like this since you have to follow everything closely so there are no mistakes. 😄

miguelmartins17 commented 4 years ago

@nelsonic Where should I click now ?

Screen Shot 2020-02-09 at 14 10 59

nelsonic commented 4 years ago

@miguelmartins17 what are the options when you click on "Review changes"?