search

dwyl / learn-flutter

🦋 Learn how to use Flutter to Build Cross-platform Native Mobile Apps
https://flutter.dev
GNU General Public License v2.0
73 stars 8 forks source link

Adding Lessons About TDD Clean Architecture Course #45

Closed miguelmartins17 closed 4 years ago

miguelmartins17 commented 4 years ago

Adding titles and video link

miguelmartins17 commented 4 years ago

@nelsonic Can we merge the pull request now?

nelsonic commented 4 years ago

@miguelmartins17 my review comment above stated how the PR could be improved. Without the complete code at the end of each step these notes are incomplete. Imagine you are writing an exam (_in a STEM subject_), you have written down all the calculations but not the final answers to the questions. What grade would you expect to get on the Exam? In the real world, without the answers you would get an F (8/20) for the work you have done. You have done the hard part to get the answers but missed the final step! You can easily turn that F (8/20) into an A (20/20) by simply including the complete code.

Please try not to be impatient with getting your Pull Requests merged before they are finished. The point of an apprenticeship is to learn in a friendly environment with people who care about your future/success. That means following the instructions when they are given. I've worked with senior developers who would just close this Pull Request because merging it would waste other people's time if they tried to read it without having the code. We've seen plenty of people "let go" because they cannot follow instructions. People who don't follow instructions when the task is simple will skip steps when it gets complex. 👎 Don't skip steps and always include the complete code in examples otherwise they are worthless.

Always think to yourself that the time of person reading your work is 10-100x more "valuable" than yours. This is the philosophy I have applied since my days working as an accountant where the "Partner" was charged out at £500/hour. That's nothing! There are lawyers who charge $1700/hour. Perhaps it's difficult for you to conceptualise but there are people at the top of every industry who earn €500+ per hour. Even if you don't believe that there are 10-100x developers making millions you can at least think about it from the perspective that you are writing something that will be read by at least 100 other people, right? If you fail to include the code and those 100 people are forced to waste 20 minutes each trying to understand the gaps in the notes, you've just wasted 2000 min (100 x 20) or 33.3 hours. Just by skipping a step you have wasted several days of other people's time. ⌛️🔥

Don't waste anyone's time by neglecting to include the complete code. 5 minutes of your time now can save days of other people's time!

Please git clone git@github.com:dwyl/learn-flutter.git && cd learn-flutter the repo onto your localhost (if you haven't already done it). Then git checkout miguelmartins17-patch-3 the miguelmartins17-patch-3 branch. Create a folder called /tdd-architecture-example. Move the complete code into that folder and git commit the code, e.g: git add . && git commit -m 'adds complete code at the end of video 9 for #42' thengit push origin miguelmartins17-patch-3` the branch back to GitHub. Thanks. ✨