dwyl / learn-flutter

🦋 Learn how to use Flutter to Build Cross-platform Native Mobile Apps
https://flutter.dev
GNU General Public License v2.0
73 stars 8 forks source link

Feat: `i18n` in `Flutter` #90

Closed nelsonic closed 1 year ago

nelsonic commented 1 year ago

So far we have built all our Flutter demo apps in English 🇬🇧 which is fine for the 1.5 Billion people who speak it ... 💭 But what about the other 6.2 Billion i.e. 85% of the world who don't speak English...? 🤷‍♂️ We have people in our Team/Org (e.g: our Housekeeper and Foreman) who don't speak or read a word of English. 😮 To make our App useful to them, we need to translate it to their language. 🇵🇹

Todo

We will be implementing this in our App ASAP to make it useful to the people we are already working with. We want to translate everything in it including placeholders and menus at the tap of a language icon.

Bonus Level!

Note: while I don't expect this to take longer than T1d because it appears to be well-documented in: https://docs.flutter.dev/development/accessibility-and-localization/internationalization If it does end up taking a bit longer in practice, that's fine, just time-box it and leave regular comments on this issue.

nelsonic commented 1 year ago

@LuchoTurtle you've made a good demo of i18n in https://github.com/dwyl/flutter-navigation-menu-demo/pull/5 🎉 We need to document it comprehensively. 📝 Please confirm you are happy to do this as your next task so that it's still fresh in your head. 🙏

LuchoTurtle commented 1 year ago

I think I've documented the process in https://github.com/dwyl/flutter-navigation-menu-demo/pull/5. Would it make sense to just refer to it from this document? Or would you prefer I implement i18n dwyl/flutter-todo-list-tutorial or dwyl/flutter-bloc-tutorial and document in the respective readme and then refer to it from the learn-flutter repo?

nelsonic commented 1 year ago

I think as long as we have somewhere this is documented we can deep-link to it from the learn-flutter/README.md 👌 We will need to set this up in the App next so the docs need to be Gucci. 😉

LuchoTurtle commented 1 year ago

I personally wrote the section as a standalone section and I personally believe it's sufficient - https://github.com/dwyl/flutter-navigation-menu-demo/blob/fix-%234/README.md#6-adding-i18n-to-our-app - to be deep-linked from learn-flutter/README.md. We'd just have to wait for it to be merged to do so. 👍

LuchoTurtle commented 1 year ago

@nelsonic should I deep link in the learn-flutter repo to this README to close this issue?

nelsonic commented 1 year ago

Yes, please. 🙏