Started the guide - Githubissues

dwyl / learn-html5

:earth_africa: Learn how to use HTML5 (from scratch) to build websites/web applications!

GNU General Public License v2.0

35 stars 8 forks source link

Started the guide #5

Closed karinakozarova closed 7 years ago

karinakozarova commented 7 years ago

Updated the readme with little information and what should be added in the future.

nelsonic commented 7 years ago

@karinakozarova this is looking good so far! please assign the Pull Request for review when you want someone to review and merge. 👍

iteles commented 7 years ago

@karinakozarova A little tip from someone who has been looking into project histories a lot lately - if you could add a little more detail to your commit messages, that will be super useful for developers who come after you and are looking for specific things.

For the ones above, I would suggest commit messages along something like this:

Adds introduction on what is HTML to readme #3
Adds HTML basics #3
Adds HTML syntax #3

No need to change anything of course but just wanted to give you a tip for the future! Developers in later years will love you ;)

karinakozarova commented 7 years ago

Hello 😄 I started the guide. Can you give me some tips on what to adjust? And if anything looks really bad? Thanks in advance.

karinakozarova commented 7 years ago

@iteles @nelsonic maybe time to merge so that others can start contributing too?

iteles commented 7 years ago

@karinakozarova So sorry I didn't spot this earlier! Will do a little reviewing asap and get it merged in 🙌

karinakozarova commented 7 years ago

Thanks, will fix it asap.