search

dwyl / learn-istanbul

:checkered_flag: Learn how to use the Istanbul JavaScript Code Coverage Tool
339 stars 41 forks source link

removed redundant bits of code #8

Closed FullStackForger closed 8 years ago

FullStackForger commented 8 years ago

Favouring KISS principle, there is no need for node ./node_modules/.bin/ in package.json.
And here is why:

  1. Scripts configured in package.json auto execute binaries from ./node_modules/.bin
  2. ./node_modules/.bin/istanbul is an executable node script, no need to prefix it with node
codecov-io commented 8 years ago

Current coverage is 100.00%

Merging #8 into master will not affect coverage as of 09084b7

@@            master      #8   diff @@
======================================
  Files            1       1       
  Stmts           27      27       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit             27      27       
  Partial          0       0       
  Missed           0       0

Review entire Coverage Diff as of 09084b7

Powered by Codecov. Updated on successful CI builds.

nelsonic commented 8 years ago

merging. :+1: thanks.