Issue with default expiry time

dwyl / learn-json-web-tokens

:closed_lock_with_key: Learn how to use JSON Web Token (JWT) to secure your next Web App! (Tutorial/Example with Tests!!)

MIT License

4.18k stars 254 forks source link

Open alanshaw opened 9 years ago

alanshaw commented 9 years ago

The intention is to expire in 7 days, but the code doesn't provide a number thats 7 days ahead of now...far from it! https://github.com/dwyl/learn-json-web-tokens/blob/master/example/lib/helpers.js#L39

$ node
> var x = Math.floor(new Date().getTime()/1000) + 7*24*60*60
undefined
> new Date(x)
Sat Jan 17 1970 15:46:41 GMT+0000 (BST)
>

I used this instead:

Date.now() + (1000 * 60 * 60 * 24 * 7)

nelsonic commented 9 years ago

@alanshaw much betterer! :+1: Do you have time to submit as PR?

emersonmellado commented 7 years ago

PR out #78

nelsonic commented 7 years ago

Gents, my reading of this SO Question/Answer: https://stackoverflow.com/questions/28738168/how-to-create-jwt-exp-style-date-in-javascript is that we need to divide by 1000 to convert to seconds for exp ...

emersonmellado commented 7 years ago

I think we solved it from an expiration point of view by adding the '7d' option.

What I see now is that we have travis-ci not happy about that change and I'm not sure how to debug it.

emersonmellado commented 7 years ago

PR #79 out for test fix. green build this time :)

nelsonic commented 7 years ago

@emersonmellado thanks again for making time to fix this! 👍