Node Version on Travis-CI (Failing Build for Unsupported version of Node v.7) - Githubissues

dwyl / learn-json-web-tokens

:closed_lock_with_key: Learn how to use JSON Web Token (JWT) to secure your next Web App! (Tutorial/Example with Tests!!)

MIT License

4.18k stars 254 forks source link

Node Version on Travis-CI (Failing Build for Unsupported version of Node v.7) #80

Closed nelsonic closed 5 years ago

nelsonic commented 6 years ago

https://travis-ci.org/dwyl/learn-json-web-tokens/builds/290336271

And yet, when I re-run the build it passes: https://travis-ci.org/dwyl/learn-json-web-tokens/jobs/290336273

Can/Should we re-write the example/tests to be more reliable...?

Or can we simply remove the Node v.7 from .travis.yml and focus on "current" version? see: https://github.com/dwyl/learn-json-web-tokens/blob/09465e2ab2cda3bf5717ac82bc8acbb4e546ca93/.travis.yml#L4 and: https://github.com/nodejs/Release#release-schedule1

nelsonic commented 5 years ago

Fixed by https://github.com/dwyl/learn-json-web-tokens/pull/96 ✅