search

dwyl / learn-payment-processing

💳 Learn how to process online payments in your web application (and in Elixir)! 💰
36 stars 2 forks source link

[PR] Adding concepts clarification and tutorial #2

Closed LuchoTurtle closed 1 year ago

LuchoTurtle commented 1 year ago

closes #1

This PR should be the initial template for the project. Has a section describing concepts for better understanding and a tutorial to follow through integration with Stripe.

LuchoTurtle commented 1 year ago

Even though it's still in progress, @nelsonic you can take a look at the "theory" part and check if there's anything big missing in it, before I start doing an example. I didn't think going over the features of each alternative would be worthwhile from an engineering standpoint, as that is just marketing, imo.

LuchoTurtle commented 1 year ago

Added Stripe integration. It should be fully working, with authentication and checkout sessions. I still want to expand the example more, though. Even though this works, I still want to block user access of unpaid users. Still need to see how that can be implemented with Stripe's API 🤔

nelsonic commented 1 year ago

Sounds good. keep going. looking forward to reading your research findings. 👌

LuchoTurtle commented 1 year ago

This should be done. I've added the project, used DETS for storage (no need for PostgreSQL here) and I got it running with 100% coverage.

Fixed some README typos and changed the Fork example you mentioned in the feedback.

I also added CI (but it didn't execute in this PR).

nelsonic commented 1 year ago

you-are-the-product

nelsonic commented 1 year ago 
** (Mix) Expected one or more files/patterns to be given to mix format or for a .formatter.exs file to exist with an :inputs or :subdirectories key

https://github.com/dwyl/learn-payment-processing/actions/runs/3828017445/jobs/6513143646

image
nelsonic commented 1 year ago

https://github.com/dwyl/learn-payment-processing/actions/runs/3901637053/jobs/6663723897#step:6:152 image

codecov[bot] commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@da457e4). Click here to learn what that means. The diff coverage is n/a.

@@           Coverage Diff            @@
##             main        #2   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?         9           
  Lines           ?        38           
  Branches        ?         0           
========================================
  Hits            ?        38           
  Misses          ?         0           
  Partials        ?         0

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

nelsonic commented 1 year ago

Note: I made a few tweaks but your core content is excellent. Keep up the great work. 🚀