dwyl / learn-qunit

:white_check_mark: A quick introduction to JavaScript unit testing with QUnit
52 stars 10 forks source link

Pull request: 1 clarification and 2 small amendments to README.md and tests.js #1

Closed iteles closed 10 years ago

iteles commented 10 years ago

As we briefly discussed, I've made a couple of suggested alterations to two files:

  1. README.md:
  2. Amended './resources/tests.js' to './test/tests.js' in index.html code snippet
  3. Changed 2 spelling mistakes
  4. Added one clarification to the equal() assertion explaining the parameters
  5. test/tests.js
  6. Removed the third parameter in the equal() assertions; this was 'true' for all of them and according to the qunit.js documentation, this optional third parameter should actually contain a message (although this in itself is not super useful if the test is named properly, unless there are lots of equal() assertions in one test). -> http://api.qunitjs.com/category/assert/

I hope these are helpful! Ines

nelsonic commented 10 years ago

Everything is Awesome!